Skip to content

Bug 1749624: data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 6, 2019
Merged

Bug 1749624: data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m #2324

openshift-merge-robot merged 1 commit into from
Sep 6, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Sep 6, 2019

Backport #2279.

@wking
data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m
d3d790f 
Up from their default 10 minutes, using the knob that dates back to
the original network load balancer support [1].  This should help us
avoid the [2]:

  Error: timeout while waiting for state to become 'active' (last state: 'provisioning', timeout: 10m0s)

that cropped up again this week.  20m matches the timeout we set for
routes and security groups in 246f4a1 (data/aws: 20-minute create
timeouts for routes and security groups, 2019-04-26, openshift#1682).
Sometimes even 20m will not be enough [3], but should make us a bit
more resilient anyway.

[1]: hashicorp/terraform-provider-aws@1af53b1#diff-f4b0dbdc7e3eede6ba70cd286c834f37R92
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1717604
[3]: https://bugzilla.redhat.com/show_bug.cgi?id=1717604#c15
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 6, 2019

@wking: This pull request references Bugzilla bug 1749624, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1749624: data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@sdodson
Copy link
Member

sdodson commented Sep 6, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 877cae1 into openshift:release-4.1 Sep 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 6, 2019

@wking: All pull requests linked via external trackers have merged. Bugzilla bug 1749624 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1749624: data/aws/vpc/master-elb: Bump load-balancer timeouts to 20m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the bump-load-balancer-timeouts branch September 6, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @openshift-ci-robot @sdodson @mfojtik @openshift-merge-robot